mirror of
https://github.com/actions/setup-java.git
synced 2024-11-23 14:36:09 +08:00
Avoid sbt cache being invalidated for a library that is only incrementing it's own version
While working on https://github.com/guardian/gha-scala-library-release-workflow I noticed that no matter how many times I ran the workflow, `actions/setup-java` would always report `sbt cache is not found`, even if there had been no substantial change in the project - simply that `version.sbt` (the file used by https://github.com/sbt/sbt-release) had the version number in it incremented (as in b2152325ba
).
This meant that turning on `cache: sbt` would actually slow the workflow considerably, as it would never benefit from the cache being present, and would always have to save it, which could take 2-3 minutes - even though it can't take advantage of the data it's saving.
As such, it would be great to exclude `version.sbt` files from the cache hash key.
Background: `cache: sbt` was orginally introduced with https://github.com/actions/setup-java/pull/302
This commit is contained in:
parent
16ef37f8dd
commit
f228ab54b9
BIN
dist/index.js
generated
vendored
Normal file
BIN
dist/index.js
generated
vendored
Normal file
Binary file not shown.
@ -58,7 +58,8 @@ const supportedPackageManager: PackageManager[] = [
|
||||
'**/*.sbt',
|
||||
'**/project/build.properties',
|
||||
'**/project/**.scala',
|
||||
'**/project/**.sbt'
|
||||
'**/project/**.sbt',
|
||||
'!**/version.sbt' // releasing a new version of a library project shouldn't invalidate the entire sbt cache
|
||||
]
|
||||
}
|
||||
];
|
||||
|
Loading…
Reference in New Issue
Block a user