docker/actions-toolkit
1
0
Fork 0
mirror of https://github.com/docker/actions-toolkit.git synced 2024-11-23 19:56:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #50 from crazy-max/github-throw-runtime-token

Browse Source 
github: throw if runtime token invalid
This commit is contained in:
CrazyMax 2023-02-20 10:17:13 +01:00 committed by GitHub
commit d153cfaf3c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
__tests__/github.test.ts
View File

@ -130,18 +130,12 @@ describe('printActionsRuntimeTokenACs', () => {
process.env = originalEnv; process.env = originalEnv;
}); });
it('empty', async () => { it('empty', async () => {
const warnSpy = jest.spyOn(core, 'warning');
process.env.ACTIONS_RUNTIME_TOKEN = ''; process.env.ACTIONS_RUNTIME_TOKEN = '';
await GitHub.printActionsRuntimeTokenACs(); await expect(GitHub.printActionsRuntimeTokenACs()).rejects.toThrowError(new Error('ACTIONS_RUNTIME_TOKEN not set'));
expect(warnSpy).toHaveBeenCalledTimes(1);
expect(warnSpy).toHaveBeenCalledWith(`ACTIONS_RUNTIME_TOKEN not set`);
}); });
it('malformed', async () => { it('malformed', async () => {
const warnSpy = jest.spyOn(core, 'warning');
process.env.ACTIONS_RUNTIME_TOKEN = 'foo'; process.env.ACTIONS_RUNTIME_TOKEN = 'foo';
await GitHub.printActionsRuntimeTokenACs(); await expect(GitHub.printActionsRuntimeTokenACs()).rejects.toThrowError(new Error("Cannot parse GitHub Actions Runtime Token: Invalid token specified: Cannot read properties of undefined (reading 'replace')"));
expect(warnSpy).toHaveBeenCalledTimes(1);
expect(warnSpy).toHaveBeenCalledWith(`Cannot parse Actions Runtime Token: Invalid token specified: Cannot read properties of undefined (reading 'replace')`);
}); });
it('refs/heads/master', async () => { it('refs/heads/master', async () => {
const infoSpy = jest.spyOn(core, 'info'); const infoSpy = jest.spyOn(core, 'info');

8
src/github.ts
View File

@ -59,12 +59,10 @@ export class GitHub {
try { try {
jwt = GitHub.actionsRuntimeToken; jwt = GitHub.actionsRuntimeToken;
} catch (e) { } catch (e) {
core.warning(`Cannot parse Actions Runtime Token: ${e.message}`); throw new Error(`Cannot parse GitHub Actions Runtime Token: ${e.message}`);
return;
} }
if (!jwt) { if (!jwt) {
core.warning(`ACTIONS_RUNTIME_TOKEN not set`); throw new Error(`ACTIONS_RUNTIME_TOKEN not set`);
return;
} }
try { try {
<Array<GitHubActionsRuntimeTokenAC>>JSON.parse(`${jwt.ac}`).forEach(ac => { <Array<GitHubActionsRuntimeTokenAC>>JSON.parse(`${jwt.ac}`).forEach(ac => {
@ -85,7 +83,7 @@ export class GitHub {
core.info(`${ac.Scope}: ${permission}`); core.info(`${ac.Scope}: ${permission}`);
}); });
} catch (e) { } catch (e) {
core.warning(`Cannot parse Actions Runtime Token Access Controls: ${e.message}`); throw new Error(`Cannot parse GitHub Actions Runtime Token ACs: ${e.message}`);
} }
} }
} }